Add advanced option for custom message in preferences#1636
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds an advanced configuration option to display custom messages in the Preferences window, which is particularly useful for corporate installations where administrators might want to show information or instructions to users.
- Added
customPreferencesMessagesetting to default configuration - Implemented display logic for custom messages in preferences UI
- Added styling for the custom message display area
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| app/utils/defaultSettings.js | Added new customPreferencesMessage setting with empty string default |
| app/preferences-renderer.js | Added logic to display custom message and updated navigation handling |
| app/css/preferences.css | Added styling for the custom message display area |
| README.md | Added documentation for the new custom message feature |
| CHANGELOG.md | Added entry for the new advanced option |
| const toBeDisplayed = | ||
| document.querySelector(`.${event.target.closest('[data-section]').getAttribute('data-section')}`) | ||
| const toBeDisplayed = document.querySelector(`.${event.target.closest('[data-section]').getAttribute('data-section')}`) | ||
| document.querySelectorAll('body > div:not(.custom-message)').forEach(section => { |
There was a problem hiding this comment.
[nitpick] The selector hardcodes the .custom-message class which creates tight coupling. Consider using a data attribute or a more semantic approach to exclude the custom message from section hiding logic.
Suggested change
| document.querySelectorAll('body > div:not(.custom-message)').forEach(section => { | |
| document.querySelectorAll('body > div:not([data-exclude="true"])').forEach(section => { |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.